Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE/#255 알림 목록 조회 기능 구현 #259

Merged
merged 3 commits into from
Oct 4, 2023
Merged

BE/#255 알림 목록 조회 기능 구현 #259

merged 3 commits into from
Oct 4, 2023

Conversation

kimhalin
Copy link
Contributor

@kimhalin kimhalin commented Oct 4, 2023

🛠️ 변경사항

  • 알림 목록 조회 페이징으로 구현했습니다!
    image


☝️ 유의사항



👀 참고자료



❗체크리스트

  • 하나의 메소드는 최소의 기능만 하도록 설정했나요?
  • 수정 가능하도록 유연하게 작성했나요?
  • 필요 없는 import문이나 setter 등을 삭제했나요?
  • 기존의 코드에 영향이 없는 것을 확인하였나요?

@kimhalin kimhalin self-assigned this Oct 4, 2023
@kimhalin kimhalin linked an issue Oct 4, 2023 that may be closed by this pull request
[feat] 알림 목록 조회 구현 #255
Closed
2 tasks
@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

Unit Test Results

88 tests  ±0   88 ✔️ ±0   4s ⏱️ -1s
19 suites ±0     0 💤 ±0 
19 files   ±0     0 ❌ ±0 

Results for commit 7e3f895. ± Comparison against base commit 41cd47a.

♻️ This comment has been updated with latest results.

baekhangyeol
baekhangyeol approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@baekhangyeol baekhangyeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨어요😊

youKeon
youKeon approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@youKeon youKeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! LGTM!!

@kimhalin kimhalin merged commit 98c1db9 into feature Oct 4, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youKeon youKeon youKeon approved these changes

@baekhangyeol baekhangyeol baekhangyeol approved these changes

Assignees

@kimhalin kimhalin

Labels
기능구현
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 알림 목록 조회 구현
3 participants
@kimhalin @baekhangyeol @youKeon